Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1707

add double quotes to escape spaces in paths in e2e

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/viankakrisna/spaces into master 8 years ago
  • Overview 13
  • Commits 3
  • Pipelines 0
  • Changes 5

Created by: viankakrisna

Plans to fix https://github.com/facebookincubator/create-react-app/issues/1652 This happens when you clone create-react-app to a path where it has spaces in any of the parent foldes.

To test it, just rename your parent folder to something with spaces and run npm run e2e

Activity

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
  1. 03 Mar, 2017 3 commits
    • Ade Viankakrisna Fadlil's avatar
      escape spaces in path for all e2e tests · 0fdb4941
      Ade Viankakrisna Fadlil authored 8 years ago
      0fdb4941
    • Ade Viankakrisna Fadlil's avatar
      Change $* to "$@" props to @n3tr · f10b7a7c
      Ade Viankakrisna Fadlil authored 8 years ago
      f10b7a7c
    • Ade Viankakrisna Fadlil's avatar
      add double quotes to escape spaces in path · 759abc1f
      Ade Viankakrisna Fadlil authored 8 years ago
      759abc1f
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: firstcontributions/first-contributions!53384
Source branch: github/fork/viankakrisna/spaces

Menu

Explore Projects Groups Snippets