Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1729

Lint internal scripts with eslint:recommended

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/simplify-own-linting into master 8 years ago
  • Overview 1
  • Commits 2
  • Pipelines 0
  • Changes 13

Created by: gaearon

It didn't make a lot of sense to use CRA's own linting setup because we're in a different environment (Node). It was also a pain to do this with our monorepo setup because we'd always trail a version behind. This seems much simpler and will hopefully unbreak master.

Compare
  • master (base)

and
  • latest version
    8ff318ee
    2 commits, 2 years ago

13 files
+ 45
- 13

    Preferences

    File browser
    Compare changes
pack‎ages‎
eslint-conf‎ig-react-app‎
inde‎x.js‎ +2 -0
react-d‎ev-utils‎
checkRequi‎redFiles.js‎ +2 -0
clearCo‎nsole.js‎ +2 -0
formatWebpac‎kMessages.js‎ +2 -0
getProcess‎ForPort.js‎ +11 -0
openBro‎wser.js‎ +2 -0
prom‎pt.js‎ +3 -1
webpackHotD‎evClient.js‎ +3 -1
react-‎scripts‎
b‎in‎
react-sc‎ripts.js‎ +2 -2
fixtures/kitchen‎sink/integration‎
initD‎OM.js‎ +1 -1
ta‎sks‎
e2e-si‎mple.sh‎ +1 -1
.esl‎intrc‎ +14 -1
packag‎e.json‎ +0 -6
packages/eslint-config-react-app/index.js
+ 2
- 0
  • View file @ 8ff318ee

  • Edit in single-file editor

  • Open in Web IDE


@@ -7,6 +7,8 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
// Inspired by https://github.com/airbnb/javascript but less opinionated.
// We use eslint-loader so even warnings are very visible.
packages/react-dev-utils/checkRequiredFiles.js
+ 2
- 0
  • View file @ 8ff318ee

  • Edit in single-file editor

  • Open in Web IDE


@@ -7,6 +7,8 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
var fs = require('fs');
var path = require('path');
var chalk = require('chalk');
packages/react-dev-utils/clearConsole.js
+ 2
- 0
  • View file @ 8ff318ee

  • Edit in single-file editor

  • Open in Web IDE


@@ -7,6 +7,8 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
function clearConsole() {
process.stdout.write(process.platform === 'win32' ? '\x1Bc' : '\x1B[2J\x1B[3J\x1B[H');
}
packages/react-dev-utils/formatWebpackMessages.js
+ 2
- 0
  • View file @ 8ff318ee

  • Edit in single-file editor

  • Open in Web IDE


@@ -7,6 +7,8 @@
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
// WARNING: this code is untranspiled and is used in browser too.
// Please make sure any changes are in ES5 or contribute a Babel compile step.
packages/react-dev-utils/getProcessForPort.js
+ 11
- 0
  • View file @ 8ff318ee

  • Edit in single-file editor

  • Open in Web IDE


/**
* Copyright (c) 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
var chalk = require('chalk');
var execSync = require('child_process').execSync;
var path = require('path');
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: facebook/create-react-app!45
Source branch: github/fork/gaearon/simplify-own-linting

Menu

Explore Projects Groups Snippets