Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1808

Only run tests in <rootDir>/src (#544)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/kindrowboat/master into master Mar 13, 2017
  • Overview 6
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: kindrowboat

  • updates Jest to 19.0.2

  • removes testPathIgnorePatterns from jest config

  • adds testMatch to jest config to only match files in src

This change was verified by:

  1. forking and cloning create-react-app in a cloud9 environment
  2. creating a new test project using create-react-app
  3. running test and seeing
    1. the provided template test passing
    2. a metadata file in cloud9 with the same name failing because it is not a test and only JSON data
  4. making fix in react-scripts (see patch)
  5. updating the package.json of test project to use modified create-react-app
  6. running tests and seeing only the one template test passing
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/kindrowboat/master