Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1810

Fixes a silent crash when ejecting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/fix-eject into master Mar 13, 2017
  • Overview 11
  • Commits 5
  • Pipelines 0
  • Changes 6

Created by: gaearon

This only affects master, not any stable releases.

It should fix the main problem in #1806 (closed) although we still shouldn't close the issue until we fix the end-to-end tests and make eject crash on error.

I'd appreciate the review because I haven't really tested it. We can look at Travis logs to verify it worked.

I want to merge this sooner than other issues in #1806 (closed) so that less forkers who track master are affected.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gaearon/fix-eject