Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1854

Add flow typechecking as a webpack plugin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Gregoor/master into master 8 years ago
  • Overview 2
  • Commits 33
  • Pipelines 0
  • Changes 8

Created by: Gregoor

Based on this PR by @rricard but without adding flow-typed to the gitignore.

Activity

  • Loading
  • Loading
Please register or sign in to reply
  1. 18 Mar, 2017 1 commit
    • Gregor Weber's avatar
      Don't put flow-typed on gitignore · 1e21de78
      Gregor Weber authored 8 years ago
      1e21de78
  2. 09 Dec, 2016 5 commits
    • Robin Ricard's avatar
      Merge branch 'tests-in-webpack' into rricard-master · 42fcb3cb
      Robin Ricard authored 8 years ago
      # Conflicts:
      #	packages/react-scripts/config/webpack.config.dev.js
      #	packages/react-scripts/config/webpack.config.prod.js
      42fcb3cb
    • Robin Ricard's avatar
      Refine globbing · 07a556e5
      Robin Ricard authored 8 years ago
      07a556e5
    • Robin Ricard's avatar
      Don't reinit flow in a child compilation · 36391470
      Robin Ricard authored 8 years ago
      36391470
    • Robin Ricard's avatar
      Ignore directories in test glob · 58e82874
      Robin Ricard authored 8 years ago
      58e82874
    • Robin Ricard's avatar
      Ignore directories in test glob · 7489f54e
      Robin Ricard authored 8 years ago
      7489f54e
  3. 08 Dec, 2016 27 commits
    • Robin Ricard's avatar
      Only consider src tests · 74705ffa
      Robin Ricard authored 8 years ago
      74705ffa
    • Robin Ricard's avatar
      Merge branch 'tests-in-webpack' · 494b3926
      Robin Ricard authored 8 years ago
      # Conflicts:
      #	packages/react-dev-utils/package.json
      #	packages/react-scripts/config/webpack.config.dev.js
      494b3926
    • Robin Ricard's avatar
      Only change gitignore if we create a flowconfig · 46829e3f
      Robin Ricard authored 8 years ago
      46829e3f
    • Robin Ricard's avatar
      In e2e: assert flow is correctly showing errors · be43c83a
      Robin Ricard authored 8 years ago
      be43c83a
    • Robin Ricard's avatar
      Remove info about the .flowconfig in the docs · c0188d90
      Robin Ricard authored 8 years ago
      It's now useless
      c0188d90
    • Robin Ricard's avatar
      Remove flow-typed lib import (known by default!) · 52e207af
      Robin Ricard authored 8 years ago
      52e207af
    • Robin Ricard's avatar
      Remove fbjs ignores now that it's fixed · 3b06bf1c
      Robin Ricard authored 8 years ago
      3b06bf1c
    • Robin Ricard's avatar
      Run flow even if init failed · 911bf6d1
      Robin Ricard authored 8 years ago
      911bf6d1
    • Robin Ricard's avatar
      Add optional flow to end to end testing · 4ed28fd7
      Robin Ricard authored 8 years ago
      4ed28fd7
    • Robin Ricard's avatar
      Add flow-typed to gitignore automatically · 251bd9bc
      Robin Ricard authored 8 years ago
      251bd9bc
    • Robin Ricard's avatar
      Check global flow version · 3fc87cab
      Robin Ricard authored 8 years ago
      If a mismatch occurs, the DX will be bad, we should tell it to the user
      3fc87cab
    • Robin Ricard's avatar
      Get flow version internally without config · aa76ae5a
      Robin Ricard authored 8 years ago
      aa76ae5a
    • Robin Ricard's avatar
      Process code-based flow checks · c001833c
      Robin Ricard authored 8 years ago
      c001833c
    • Robin Ricard's avatar
      Schedule project init to complete before 1st check · 7e65c5d3
      Robin Ricard authored 8 years ago
      7e65c5d3
    • Robin Ricard's avatar
      Add documentation for out-of-the-box flow · bf66320e
      Robin Ricard authored 8 years ago
      bf66320e
    • Robin Ricard's avatar
      Refactor using promises and no class attrs · 64f36ec7
      Robin Ricard authored 8 years ago
      64f36ec7
    • Robin Ricard's avatar
      Use arrow functions · a4e56321
      Robin Ricard authored 8 years ago
      a4e56321
    • Robin Ricard's avatar
      Move options as explicit props of the plugin · d724efef
      Robin Ricard authored 8 years ago
      d724efef
    • Robin Ricard's avatar
      Reset server stderr on restart · e4b915cd
      Robin Ricard authored 8 years ago
      e4b915cd
    • Robin Ricard's avatar
      Add flow-typed resolution at start · 79911f82
      Robin Ricard authored 8 years ago
      79911f82
    • Robin Ricard's avatar
      Add flow ignore comment to the start hints · 8ce4c6f3
      Robin Ricard authored 8 years ago
      8ce4c6f3
    • Robin Ricard's avatar
      Run flow as a server and check with status · 097d7d97
      Robin Ricard authored 8 years ago
      097d7d97
    • Robin Ricard's avatar
      Make flow fail on CI builds · eddd11b6
      Robin Ricard authored 8 years ago
      We don't need complex logic with process.env on the plugin side, we let the build script figure this out!
      eddd11b6
    • Robin Ricard's avatar
      Setup a plugin to run a flow checking lifecycle · e332fe51
      Robin Ricard authored 8 years ago
      This will only run if a @flow annotation is seen:
      - At the first @flow file found:
        - Write a .flowconfig if none exists
        - [Not done yet] Run flow-typed install
        - [Not done yet] Start a flow instance
      - When a file with an @flow comment changes during a compilation:
        - [Not done yet] Run a flow check
        - If there are some errors in flow:
          - If CI: output as an error
          - If not CI: output as a warning
      e332fe51
    • Robin Ricard's avatar
      Create some sub compilations for tests · e0d373b2
      Robin Ricard authored 8 years ago
      This result will not be used for serving the pages but will be used for tracking lint/type errors in those files
      e0d373b2
    • Robin Ricard's avatar
      Structure where to put upcoming module addition · 19f86d15
      Robin Ricard authored 8 years ago
      19f86d15
    • Robin Ricard's avatar
      Watch test files (so they retrigger webpack) · 8e15dc20
      Robin Ricard authored 8 years ago
      This will not process them for now...
      8e15dc20
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!1854
Source branch: github/fork/Gregoor/master

Menu

Explore Projects Groups Snippets