Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1866

Warn about duplicate dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/darrenscerri/0.9.x into 0.9.x 8 years ago
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 4

Created by: darrenscerri

Add duplicate-package-checker-webpack-plugin as proposed here: #1844 . Display compilation warnings on build.

duplicate packages

This feature can be quickly tested by creating an app, installing an old version of fbjs (yarn add fbjs@0.6.0) and importing fbjs from App.js. This will result in having duplicate fbjs packages since React already requires the most recent version of fbjs.

Approval is optional

Closed by (Jul 25, 2025 8:27am UTC)

Loading

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

    If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    Does anyone have an idea why build is failing on AppVeyor? It says curl: command not found, but I can see that previous builds with curl have been passing.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    @gaearon should we put this in a 0.9 release or 0.10?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    I'm going to punt this to 0.10 for now since some people rely on CI to check warnings and consider them build failures. I don't want to accidentally upset anyone.

    Sorry for the wait, @darrenscerri!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    Ok, makes sense.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    @darrenscerri could you please close this PR and open a new one from a feature branch that's on master?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    @Timer Ok done: #2011

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Thanks so much, @darrenscerri!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: new feature
2
CLA Signed tag: new feature
    Assign labels
  • Manage project labels

Milestone
1.0.0
1.0.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!1866
Source branch: github/fork/darrenscerri/0.9.x

Menu

Explore Projects Groups Snippets