Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !1868

Fix AppVeyor CI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/darrenscerri/appveyor into 0.9.x 8 years ago
  • Overview 20
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: darrenscerri

https://github.com/facebookincubator/create-react-app/issues/1865

Loading
Loading

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

    If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Are you interested in reopening this PR? You need not create a new one to make the change in #1865 (closed).

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: facebook-github-bot

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    There seems to be another error but looks like it is unrelated though.

    Error: EPERM: operation not permitted, symlink when running npm link

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Can we try the lerna concurrency flag again with the path fix?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    I just added a commit which removes caching (which may fix it).

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    I don't think you need to remove caching—you can bust the cache by editing appveyor.cleanup-cache.txt in the root.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    I read that NPM permissions errors are caused by restoring a cached version of node_modules. We may not be able to use caching for AppVeyor if that's the case.

    It's on the internet. It must be true.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Hm, the status pulled from your personal AppVeyor @gaearon which looks to have a different result than https://ci.appveyor.com/project/Facebook/create-react-app/build/1.0.369

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    Still can't get this to work. Any other ideas? I tried comparing this branch to master but couldn't notice anything obvious that might trigger the permission error.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    Running AppVeyor on Visual Studio 2017 as suggested on https://github.com/appveyor/ci/issues/1437. Build is now passing on AppVeyor.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Should I merge this?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    I cleaned up other commits that removed caching and other attempts so the current changes are just for the curl.exe issue (https://github.com/appveyor/ci/issues/1426) and the other issue where the build was failing due to permission errors. It's fine to merge from my end.

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Sounds good. I'm going to be on a flight for a few hours so I'll be interested to see the build post-merge. :smile::airplane:️

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Merged by: Timer at 2017-03-24 10:52:39 UTC

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    I'll have to cherrypick this to master tonight. Thanks for looking into this!

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: darrenscerri

    :fingers_crossed:

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Awesome work folks

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    Cherry-picked as b403048f.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
5.0.0
5.0.0 (expired)
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference: OpenAPITools/openapi-generator!6812
Source branch: github/fork/darrenscerri/appveyor

Menu

Explore Projects Groups Snippets