Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2074

Eslint Config: peerDependencies -> dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/einarlove/peer-dependencies-to-dependencies-in-eslint-config into master May 03, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: einarlove

PeerDependencies is not deprecated, but they are a pain in the but.

$ yarn add eslint-config-react-app
yarn add v0.20.3
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "babel-eslint@^7.0.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint@^3.16.1".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-flowtype@^2.21.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-import@^2.0.1".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-jsx-a11y@^2.0.0 || ^3.0.0 || ^4.0.0".
warning "eslint-config-react-app@0.6.2" has unmet peer dependency "eslint-plugin-react@^6.4.1".
success Saved 1 new dependency.
└─ eslint-config-react-app@0.6.2

Since eslint-config-react-app depends on all the above packages, it should be installed alongside the package. This will mirror the same behaviour babel-preset-react-app has which is a breeze. 💨

Should eslint also be installed automatically? I'm not sure. I'm leaving it as a peerDependency for now and would like to hear your thoughts.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/einarlove/peer-dependencies-to-dependencies-in-eslint-config