update readme with fix from #1939

Created by: kellyrmilligan

updating readme with comment from #1939 (closed) . works with latest node-sass@4.5.2

Created by: Timer

Hey @kellyrmilligan, thanks for this PR!

Do you happen to know about that comment I mentioned above?

Created by: cr101

@kellyrmilligan Unfortunately, it doesn't work on Windows

Error: ENOENT: no such file or directory, lstat 'C:\wf\my-app\src***.scss'

Created by: kellyrmilligan

What if you tried app\src\**\*.scss ?

Update, I did see in a doc somewhere even on windows for globbing you should use forward slashes as well.

Created by: kellyrmilligan

i'm looking more into the code now. there are a few levels of abstraction around how the globbing works, so I may change this back to the original fix and explain in this PR why it works.

Created by: kellyrmilligan

looks like the recommended solution from the issue won't let you watch files in subdirectories. the glob pattern in the cli gets expanded, and then node-sass doesn't treat it as a directory. on the other hand, if you use src/*/**.scss, it doesn't work as you would expect either. from what I am seeing, the way they want it to be used is src/. this results in the sass-graph lib picking up all the correct files. The cli assumes you want all extensions, and its not configurable.

After trying out a few different ways of calling the cli, on my setup at least, the looping happens when you change a file that is included in a lot of files, like say a _settings.scss file or something.

I switched over to node-sass-chokidar and this issue just went away. I think longer term the node-sass cli should let you configure the extensions or use proper globbing patterns, as ATM its kind of broken IMO.

switching to node-sass-chokidar fixed this issue fully for me, so not sure what to do with this PR unless we want to switch the recommendation for sass to that package instead.

thoughts @Timer and anyone else?

Created by: Timer

Let's just switch the docs to node-sass-chokidar primarily.

Created by: gaearon

Would it work if you quoted the glob? node-sass "src/**/*.scss" Then shell wouldn’t expand it. (I don’t know if it helps or not.)

Created by: kellyrmilligan

@gaearon let me give it a shot.

Created by: kellyrmilligan

nope, it takes that as the literal value and gives Error: ENOENT: no such file or directory, lstat 'src/**/*.scss'

Created by: kellyrmilligan

I updated the readme again. I reverted it back to the way it was, and added a note under the step to install node-sass, about node-sass-chokidar.

Created by: Timer

We already have a note to switch to it about performance, but I think we should just recommend it first and adjust both notes to say why we use it.

I don't see a need to show docs using node-sass.

Created by: Timer

Perfect! Thanks much.

Created by: Timer

Just to confirm, new files aren't an issue anymore?

Created by: kellyrmilligan

@Timer added note about new files back in after testing. please let me know of any other changes I just pushed an update to the notes as well.

Created by: Timer

/cc @michaelwayman Figured you'd like to see this.

Created by: michaelwayman

That's awesome @kellyrmilligan thanks :)

And yep, files starting with _ do not get transpiled.

I think the not recognizing new files is a known bug with node-sass. Since you already have the "Why node-sass-chokidar?" section, if you want to add that nsc fixes it that would be super lol

<3 this PR BTW :)

Created by: kellyrmilligan

@michaelwayman done!

Created by: Iron-Ham

@michaelwayman

Created by: Timer

This is some great work, guys! Thanks so much.

Merged by: Timer at 2017-05-12 04:00:46 UTC

Created by: FDiskas

I suggest to use scripts like so

    "prebuild": "node-sass-chokidar src/ -o src/",
    "prestart": "npm run prebuild && node-sass-chokidar src/ -o src/ --watch --recursive"