Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2145

Don't collapse unintentional top-level errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/dont-collapse-top-unintentional into master 8 years ago
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 5

Created by: gaearon

This should fix https://github.com/facebookincubator/create-react-app/issues/2144.

If the error is one of the built-in ones, we don't collapse, and show all the internal frames up to the first instance of user code. Then collapsing logic works as before.

I found the variable overwriting confusing and hard to deal with, so I tried to separate variables. Let me know if I missed some case.

Approval is optional

Merged by (Jul 25, 2025 3:29am UTC)

Loading

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Merged by: gaearon at 2017-05-14 14:21:42 UTC

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: Timer

    LGTM.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
1.0.0
1.0.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!2145
Source branch: github/fork/gaearon/dont-collapse-top-unintentional

Menu

Explore Projects Groups Snippets