Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2175

Resolve regenerator runtime relative to react-scripts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/resolve-runtime-from-config into master May 16, 2017
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: gaearon

This removes a hack that caused an absolute path to be embedded in the modules after being processed by our Babel preset. This hack doesn’t matter for apps that are bundled, but it breaks libraries.

The hack was in the wrong place. We can’t really get around the fact that regenerator runtime is resolved from the consuming application. So instead we should embrace it, and redirect at the webpack config level instead. Additionally the preset should make it clear babel-runtime is meant to be installed by the app, so I moved it to the peer dependencies.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gaearon/resolve-runtime-from-config