Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2208

Tweaked error overlay styles (pt2)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge error-styling-pt2 into master May 18, 2017
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 5

Created by: bvaughn

Follow up from PR #2201

I think I addressed the critical things and some of the nits, including:

  • Moved margin between header and file name to header, so when content was scrolled, the header would remain more separate
  • Made build-time and runtime overlays better match
  • Secondary error <pre> style now uses yellow bg instead of red
  • "Scrollable Header" (see above comment to why this is necessary) but I did increase the max-height from 35% to 50%.
  • Fixed header and "X" button vertical alignment

Did not address:

  • Selected Line Alignment (works for me)
  • IE testing (no VM)
Runtime error (iOS)
screen shot 2017-05-18 at 12 05 12 pm
Runtime error (desktop)
screen shot 2017-05-18 at 12 05 27 pm
Build error (iOS)
screen shot 2017-05-18 at 12 09 33 pm
Build error (desktop)
screen shot 2017-05-18 at 12 09 26 pm
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: error-styling-pt2