Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2219

Improve interaction between compile and runtime overlays

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/final-tweaks-to-overlays into master May 18, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: gaearon

Last thing I wanted to fix before cutting 1.0.

This changes z-index to the actual max possible value (and one below for runtime overlay).

It also changes the logic to prevent dismissing the syntax overlay right before the page reloads. Now we only dismiss it when the page is guaranteed to stay (which is when? I’m not sure but maybe it’ll make more sense in the future).

Anyway, the point is that compile overlay should no longer disappear in flicker, just to be refreshed a few milliseconds later.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gaearon/final-tweaks-to-overlays