Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2238

Fix shortcut handling in react-error-overlay

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Gandem/fix-shortcut into master May 19, 2017
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Gandem

In regard to #2231 (closed), I tried to write a quick fix for the error, by not handling shortcuts if the error list is empty.

Tested by rebuilding react-error-overlay, and testing shortcuts.

If you think they're is a better way to do this, i'm completely open for suggestions, as I am new to create-react-app codebase !

Thanks 😄

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Gandem/fix-shortcut