Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2319

Changes no-unused-expressions lint from warning to error

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/amupitan/2303-forgetting-to-return-JSX-should-crash-build into next May 22, 2017
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: amupitan

Build crashes whenever JSX is not returned as proposed here: #2303 (closed).

The build crashes whenever JSX isn't returned, as opposed to just giving a warning.

screenshot

To test:

Create a stateless component without a return clause. For example: import React from 'react'; export default function Logo(){ <div className="App-header"> <img src="./logo.svg" className="App-logo" alt="logo" /> <h2>Welcome to React</h2> </div> }

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/amupitan/2303-forgetting-to-return-JSX-should-crash-build