Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2346

Resolve flow errors in eslint JSX a11y

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/iainbeeston/upgrade-a11y-to-resolve-flow-errors into master May 24, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: iainbeeston

Background

After upgrading my app to create-react-app 1.0.0, I started seeing flow errors, coming from eslint-plugin-jsx-a11y that's bundled with create-react-app. I've been able to reproduce in a simple test app, and you can see the flow errors raised in the circleci build for it.

What went wrong?

create-react-app currently uses eslint-plugin-jsx-a11y locked to version 5.0.1, which has a bug with it's flow types. This issue was fixed in version 5.0.2.

How have I fixed it?

I've updated the package.json file for each of the packages in create-react-app to use the latest version (5.0.3) of eslint-plugin-jsx-a11y, which has the fix. I've also removed some flow config from react-error-overlay that was explicitly ignoring the flow errors that I've been seeing (no longer needed now the underlying issue in eslint-plugin-jsx-a11y has been fixed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/iainbeeston/upgrade-a11y-to-resolve-flow-errors