Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2347

Add navigateFallbackWhitelist /__* to SW Precache config

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/ryansully/navigateFallbackWhitelist into master May 24, 2017
  • Overview 2
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ryansully

Adds navigateFallbackWhitelist to service worker precache config options in Webpack config for production builds. This solves an issue with Firebase reserved URLs not working due to the PWA service worker serving the navigateFallback URL (/index.html) when non-cached URLs are requested.

Fixes part of https://github.com/facebookincubator/create-react-app/issues/2237, specifically https://github.com/facebookincubator/create-react-app/issues/2237#issuecomment-302693219.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ryansully/navigateFallbackWhitelist