Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !235

Add Promise and fetch polyfills

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge polyfills into master Jul 27, 2016
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 5

Created by: gaearon

I used promise (maintained by @ForbesLindesay and widely used at Facebook) and fetch (pretty much standard in the community).

These will be included for everyone. In terms of size, it adds about 4kB min+gzip, and I think it’s a fair tradeoff for getting these features as baseline since they’re so commonly used in the React tutorials.

Promise rejection tracking is on in all environments. If it truly causes performance issues, we can disable it in production. However I wouldn’t expect it to: front-end code isn’t usually as Promise-heavy as Node. There’s a difference between using a Promise here and there, and creating thousands of Promises in tight loops or whatever it is that most benchmarks measure.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: polyfills