Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2400
An error occurred while fetching the assigned milestone of the selected merge_request.

Added cache clear to e2e scripts

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ro-savage/e2e-cache-fix into master 8 years ago
  • Overview 5
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: ro-savage

Fixes #2399 (closed)

Yarn is caching old react-scripts when running the e2e tests, which means old versions are being used during the build process. Fine for CI where each build is on a clean machine but breaks e2e in unforeseen ways on local machines.

This might be related to yarnpkg/yarn#2165

The fix is to run yarn clean cache before running the e2e tests.

Loading
Loading

Activity


  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Looks like that command doesn't work on AppVeyor. Probably https://github.com/yarnpkg/yarn/issues/2591.

    Worth trying https://github.com/yarnpkg/yarn/issues/2591#issuecomment-291009255?

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: ro-savage

    Issue is fixed in latest version of yarn, so decide best thing to do is just install the latest version of yarn. Once AppVeyor updates their yarn, the npm install -g yarn can be removed.

    AppVeyor issue: appveyor/ci/issues/1576

    However, now there is a new issue related to #2030 (closed). Might be caused by using the latest version of yarn on windows machines.

    Could either wait for the fix or try change this PR to use the work around gaearon mentioned.

    # Workaround for https://github.com/yarnpkg/yarn/issues/2591
    case "$(uname -s)" in
      *CYGWIN*|MSYS*|MINGW*) yarn=yarn.cmd;;
      *) yarn=yarn;;
    esac
    eval $yarn run build
  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: ro-savage

    Updated to apply the yarn=yarn.cmd fix, rather than installing the latest yarn which causes issues else where. The latest version of yarn + cra + windows 10 issue can be dealt with in #2030 (closed)

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Merged by: gaearon at 2017-05-29 18:00:43 UTC

  • Administrator
    Administrator @root · 8 years ago
    Author Contributor

    Created by: gaearon

    Is this hack still necessary? AppVeyor has been failing for a while now. I tried reverting this in https://github.com/facebookincubator/create-react-app/issues/2626 but it doesn't help. I'm super confused.

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/ro-savage/e2e-cache-fix

Menu

Explore Projects Groups Snippets