Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2429

Update sw-precache-webpack-plugin to lastest version

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/goldhand/master into master May 31, 2017
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: goldhand

Updating sw-precache-webpack-plugin to v0.11.3 will fix the following related issues:

Windows path: https://github.com/facebookincubator/create-react-app/issues/2235 Duplicate builds: https://github.com/facebookincubator/create-react-app/pull/1728#issuecomment-301998584

I have tested by running /bin/react-scripts.js build and asserting that the build log message is not emitted twice. The problem was discovered in this https://github.com/goldhand/sw-precache-webpack-plugin/pull/78 we were calling the webpack done callback twice.

I do not have a windows machine to test the windows fix but the fix is exactly the same as in this configuration. The fix is here and has been published for a couple weeks now with no issue.

In addition to these fixes, updating to 0.11.3 will allow chunk's with hashes to be "precached" and used in importScripts.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/goldhand/master