Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2430

webpack no need for `ident` if using complex options anymore

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/andykenward/feature/webpack-no-need-ident into master May 31, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: andykenward

Since v2.2.1 of Webpack, the need for ident for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options

Steps ran to check if postcss-loader and its plugins still work.

  • npm start.
  • Add to App.css.
display: flex;
user-select: none;
flex: 1 0 calc(1vw - 1px);
  • Check chrome dev tools and select element too see if postcss-flexbugs-fixes & autoprefixer work. See screenshot.
react_app_and_luisrudge_postcss-flexbugs-fixes__postcss_plugin_that_tries_to_fix_all_of_flexbug_s_issues

Then checked build version

  • npm run build
  • serve -s build
  • Check chrome dev tools and select element. See screenshot
react_app
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/andykenward/feature/webpack-no-need-ident