Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !257

Clean publish and eject

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Jiansen/clean-publish-eject into master Jul 28, 2016
  • Overview 17
  • Commits 1
  • Pipelines 0
  • Changes 23

Created by: Jiansen

  • separate dev config and prod config, including paths.js
    • part of #191
  • cleanup code on eject
    • same as in #206 , can close 206 if this PR is accepted.
    • as discussed in #206, the --smoke-test tag is kept in production code for now
  • on release, only ship configurations for production code
    • in the node_module installed at users side, there will be no --debug-template flag
  • same as above, in e2e test, when testing cli, only pack production code
  • on local dev (i.e. build and start), use dev configuration

Disscussion 1: add parameter stage to pack.sh so that

  • pack.sh prod only ship prod configurations
  • pack.sh dev only ship dev configurations
  • pack.sh test only ship test configurations
  • etc.

This can be done by removing files in package.json, and creating a few versions of .npmignore files (e.g. .npmignore.prod).

Disscussion 2: further split paths.prod.js to 2 files, paths.beforeEject.js and paths.afterEject.js; remove the // Dead code on eject:start/end block.

Question: start.js always use the dev config for webpack. Is there a reason for this? In my local test, it seems fine to use production config in a generated app.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Jiansen/clean-publish-eject