Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2596
An error occurred while fetching the assigned milestone of the selected merge_request.

turn on ascii_only for issue with emoji and regex

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/viankakrisna/fix/uglify/ascii_only into master 8 years ago
  • Overview 8
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: viankakrisna

Fixing https://github.com/facebookincubator/create-react-app/issues/2488 Verified the changes by cloning https://github.com/crabicode/create-react-app-emoji and manually editing react-scripts/config/webpack.config.prod.js Before: screen shot 2017-06-23 at 3 01 48 am After: screen shot 2017-06-23 at 3 01 08 am

Compare
  • master (base)

and
  • latest version
    6ad408f2
    1 commit, 2 years ago

1 file
+ 3
- 0

    Preferences

    File browser
    Compare changes
packages/react-scripts/config/webpack.config.prod.js
+ 3
- 0
  • View file @ 6ad408f2

  • Edit in single-file editor

  • Open in Web IDE


@@ -290,6 +290,9 @@ module.exports = {
},
output: {
comments: false,
// Turned on because emoji and regex is not minified properly using default
// https://github.com/facebookincubator/create-react-app/issues/2488
ascii_only: true,
},
sourceMap: true,
}),
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/viankakrisna/fix/uglify/ascii_only

Menu

Explore Projects Groups Snippets