Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2657

Put react-scripts in dependencies, not devDependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/gaearon/deps into master Jun 28, 2017
  • Overview 2
  • Commits 3
  • Pipelines 0
  • Changes 4

Created by: gaearon

The distinction doesn't fully make sense in React world because you need both types to bundle the app, and neither on the server. It also created problems for folks who run build on deployment. It is also inconsistent (for example promise polyfill is technically a runtime dependency but was treated as a build one). Fixes https://github.com/facebookincubator/create-react-app/issues/2655 as well.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gaearon/deps