Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2735
An error occurred while fetching the assigned milestone of the selected merge_request.

ESLint 4

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/trungdq88/master into master 8 years ago
  • Overview 2
  • Commits 5
  • Pipelines 0
  • Changes 4

Created by: trungdq88

Changes

  • Upgrades eslint-loader from 1.7.1 -> 1.9.0.
  • Add eslintPath option to eslint-loader
  • Upgrades ESLint from 3.19.0 to 4.1.1
  • Upgrades the unmet dependencies of ESlint 4.1.1.

Resolve related issues: https://github.com/facebookincubator/create-react-app/issues/2528, https://github.com/facebookincubator/create-react-app/issues/2604, https://github.com/facebookincubator/create-react-app/issues/2631

Tested with issue https://github.com/facebookincubator/create-react-app/issues/2528, verify with following script:

npm run create-react-app verify-issue-2528
cd verify-issue-2528
yarn add eslint
vim src/App.js # Add prop types to App.js

#  static propTypes = {
#    aoeu: React.PropTypes.any,
#  }

yarn run build # Should build success :tada:

Screenshot

image

Tests

Passed: https://travis-ci.org/trungdq88/create-react-app/builds/250878659

Compare
  • master (base)

and
  • latest version
    a37d5b43
    5 commits, 2 years ago

4 files
+ 7
- 5

    Preferences

    File browser
    Compare changes
pack‎ages‎
eslint-conf‎ig-react-app‎
packag‎e.json‎ +1 -1
react-‎scripts‎
con‎fig‎
webpack.co‎nfig.dev.js‎ +1 -0
webpack.con‎fig.prod.js‎ +1 -0
packag‎e.json‎ +4 -4
packages/eslint-config-react-app/package.json
+ 1
- 1
  • View file @ a37d5b43

  • Edit in single-file editor

  • Open in Web IDE


@@ -12,7 +12,7 @@
@@ -12,7 +12,7 @@
],
],
"peerDependencies": {
"peerDependencies": {
"babel-eslint": "^7.2.3",
"babel-eslint": "^7.2.3",
"eslint": "^3.19.0",
"eslint": "^4.1.1",
"eslint-plugin-flowtype": "^2.33.0",
"eslint-plugin-flowtype": "^2.33.0",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-jsx-a11y": "^5.0.3",
"eslint-plugin-jsx-a11y": "^5.0.3",
packages/react-scripts/config/webpack.config.dev.js
+ 1
- 0
  • View file @ a37d5b43

  • Edit in single-file editor

  • Open in Web IDE


@@ -136,6 +136,7 @@ module.exports = {
@@ -136,6 +136,7 @@ module.exports = {
{
{
options: {
options: {
formatter: eslintFormatter,
formatter: eslintFormatter,
 
eslintPath: require.resolve('eslint'),
// @remove-on-eject-begin
// @remove-on-eject-begin
baseConfig: {
baseConfig: {
extends: [require.resolve('eslint-config-react-app')],
extends: [require.resolve('eslint-config-react-app')],
packages/react-scripts/config/webpack.config.prod.js
+ 1
- 0
  • View file @ a37d5b43

  • Edit in single-file editor

  • Open in Web IDE


@@ -136,6 +136,7 @@ module.exports = {
@@ -136,6 +136,7 @@ module.exports = {
{
{
options: {
options: {
formatter: eslintFormatter,
formatter: eslintFormatter,
 
eslintPath: require.resolve('eslint'),
// @remove-on-eject-begin
// @remove-on-eject-begin
// TODO: consider separate config for production,
// TODO: consider separate config for production,
// e.g. to enable no-console and no-debugger only in production.
// e.g. to enable no-console and no-debugger only in production.
packages/react-scripts/package.json
+ 4
- 4
  • View file @ a37d5b43

  • Edit in single-file editor

  • Open in Web IDE


@@ -32,12 +32,12 @@
@@ -32,12 +32,12 @@
"chalk": "1.1.3",
"chalk": "1.1.3",
"css-loader": "0.28.4",
"css-loader": "0.28.4",
"dotenv": "4.0.0",
"dotenv": "4.0.0",
"eslint": "3.19.0",
"eslint": "4.1.1",
"eslint-config-react-app": "^1.0.5",
"eslint-config-react-app": "^1.0.5",
"eslint-loader": "1.7.1",
"eslint-loader": "1.9.0",
"eslint-plugin-flowtype": "2.34.0",
"eslint-plugin-flowtype": "2.34.0",
"eslint-plugin-import": "2.2.0",
"eslint-plugin-import": "2.7.0",
"eslint-plugin-jsx-a11y": "5.0.3",
"eslint-plugin-jsx-a11y": "5.1.1",
"eslint-plugin-react": "7.1.0",
"eslint-plugin-react": "7.1.0",
"extract-text-webpack-plugin": "2.1.2",
"extract-text-webpack-plugin": "2.1.2",
"file-loader": "0.11.2",
"file-loader": "0.11.2",
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/trungdq88/master

Menu

Explore Projects Groups Snippets