Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2834

fix formatWebpackMessages to return all formatted messages instead of just one error.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/onigoetz/master into master Jul 21, 2017
  • Overview 9
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: onigoetz

Hi,

I propose this change to formatWebpackMessages that currently removes all errors but one to the places in which it is used.

I propose this change because it's really surprising that when you call a function that is supposed to format messages that actually formats and removes messages.

I moved the removal of messages where they're displayed. That makes it clearer why you see only one single error and not all the errors that occured.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/onigoetz/master