Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2884

Adjust the `checkIfOnline` check if in a corporate proxy environment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bsyk/master into master Aug 01, 2017
  • Overview 12
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: bsyk

Adjust the checkIfOnline check if in a corporate proxy environment If the environment variable https_proxy is set, test that the proxy name is resolveable rather than 'registry.yarnpkg.com'.

Testing on a corporate network where proxies are required. Prior to change, installation fails as per #2832 (closed), post change installation works happily.

Before: screen shot 2017-08-01 at 11 20 11 am

After with proxy set & required: screen shot 2017-08-01 at 11 19 32 am

After with proxy not set, but required: screen shot 2017-08-02 at 9 38 04 am

After with proxy set incorrectly: screen shot 2017-08-02 at 9 38 18 am

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bsyk/master