Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2989

Resolved issue #2971

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/davidleger95/issue-#2971 into master Aug 21, 2017
  • Overview 4
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: davidleger95

  • Changed h2 to h1 in template to adhere to accessibility guidelines.
  • Added h1 styles to maintain same font size.
  • Changed div tag to the semantically correct header tag for header in template.

Verification of changes:

  1. Created new React app using the modified branch.
  2. Checked code to ensure the h2 tag has been replaced with the h1 tag.
  3. Ran npm start and verified the font size of new h1 tag matches the former h2 tag in browser.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/davidleger95/issue-#2971