Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !2995

Disable service workers until issues fixed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ubershmekel/patch-1 into master Aug 23, 2017
  • Overview 4
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: ubershmekel

See the problems in this thread.

https://github.com/facebookincubator/create-react-app/issues/2398

There are more than 83 comments there to date. Many are confused by service workers and their side effects. We should find the time to fix service workers. Until then, keeping service workers in their current state may deteriorate trust in service workers and create-react-app more than it helps creating progressive web apps.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ubershmekel/patch-1