Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3105

normalize the e2e behavior for npm link in npm 5 and below

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/viankakrisna/npm5link into master Sep 10, 2017
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 2

Created by: viankakrisna

changes in https://github.com/facebookincubator/create-react-app/pull/3026 made some build fails in node 8 (success in https://github.com/facebookincubator/create-react-app/pull/3104 and https://github.com/facebookincubator/create-react-app/pull/3026 , failed in https://github.com/facebookincubator/create-react-app/pull/2755 because of misssing dependencies). probably because npm link behavior is changed in npm 5 http://codetunnel.io/npm-5-changes-to-npm-link/

this PR tries to investigate how to normalize the npm link behavior for e2e in npm 5 and below

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/viankakrisna/npm5link