Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3123

Add mobile devices into autoprefix target.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/MitsuhideOhi/autoprefixer_configuration into master Sep 14, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: MitsuhideOhi

Problem

I realized autoprefix is not working on iOS 8 Safari from some commit between 0.9.5 and 1.0.10 release.

This is because current target browser setting in webpack configuration in react-scripts is not including mobile devices which still used by amount of users.

./packages/react-scripts/config/webpack.config.dev.js ./packages/react-scripts/config/webpack.config.prod.js

browsers: [
  '>1%',
  'last 4 versions',
  'Firefox ESR',
  'not ie < 9', // React doesn't support IE8 anyway
]

Below explains visual impact from issue.

  • Works autoprefix on react-script 0.9.5.
  • Not works autoprefix on react-script 1.0.10.

Solution

Include iOS and Android setting into the configuration.

'iOS >= 8',
'android >= 4.0'

Support above android 4.0 and iOS 8 is statistically reasonable from my point of view. Still there is room for discussion about from which version we will support though.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/MitsuhideOhi/autoprefixer_configuration