Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3235

Applies new theme and adds docs link to template

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/lukejacksonn/dark-theme into next Oct 04, 2017
  • Overview 17
  • Commits 5
  • Pipelines 0
  • Changes 3

Created by: lukejacksonn

I was inspired by the new react docs, to readdress https://github.com/facebookincubator/create-react-app/pull/1472 and give App.js some love and attention; changing as little as possible but embracing the new theme and adding a bit of responsiveness.

🙂 BEFORE

screen shot 2017-10-03 at 22 40 52

😎 AFTER

screen shot 2017-10-03 at 21 28 39

💅 CHANGES

  • Updates .App-header background-color to #282c34 from reactjs.org
  • Moves .App-intro into .App-header and added min-height: 100vh to header
  • Adds .App-link CTA highlighted in #61daFb which links to reactjs.org for reference
  • Removes .App-title and To get started, text in .App-intro for the sake of brevity
  • Aligns .App-header contents vertically and horizontally using display: flex
  • Optimises screen fit using font-size: calc(10px + 2vmin) on .App-header
  • Increases the size of the rotating icon for dramatic effect

💭 THOUGHTS

One concern I have about this design is that if a first time user goes to App.js and enters content below .App-header then it won't be immediately visible due to the header being 100vh. A solution to this would be setting the height of the header to 90vh and setting the background colour of .App or body to #20232a (the darker grey in the theme).

image

The changes, although superficial, make the first creat-react-app experience a little more magical and a little more useful. It is in keeping with the react theme and portrays a truer representation of the products build quality and underlying technologies.

I'm aware this PR is massively subjective but let me know what you think. I am more than willing to discuss/make changes if you like the general direction!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/lukejacksonn/dark-theme