Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3302

Respect process.env.GENERATE_SOURCEMAP in dev mode too

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/Andarist/webpack-dev-config/respect-generate-sourcemap into master Oct 19, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Andarist

Personally I hate source maps - because I use dev tools heavily and they just bring too much of a disconnect between what's in them and what actual code gets shipped to the browser. I often evaluate expressions in the console and I just easily look up REAL identifiers, cause all I see are mapped identifiers. This provides a terrible debugging experience for me and I always chose not to use source maps.

You already respect (for other reasons) this env variable in production config and I literally dont see any con against respecting it in dev mode too.

How did I verify my change? I've ejected in the project created with latest create-react-app, done the same changes locally and verified that it works.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Andarist/webpack-dev-config/respect-generate-sourcemap