Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3325

Update lint rules, and clarify docs around linting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/ttmarek/linting into master Oct 25, 2017
  • Overview 9
  • Commits 8
  • Pipelines 0
  • Changes 2

Created by: ttmarek

@Timer I made a long-winded issue a couple of days ago about linting. I've closed that issue because it was mostly rant. Instead, I'm proposing some changes to the ESLint rules and docs that we can iterate on in this pull request.

  1. I updated CRA's rules so they are all configured as warnings.
  2. I removed the ESLint rules that are style-specific. I did this by looking at rules that we had that were in common with those in eslint-config-prettier.
  3. I updated the docs to clarify how linting works in CRA, and to provide some tips on how to do certain things that I struggled with initially.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/ttmarek/linting