Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3435

[WIP] Make yarn workspaces work

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rmhartog/support-yarn-workspaces into master Nov 09, 2017
  • Overview 6
  • Commits 2
  • Pipelines 0
  • Changes 3

Created by: rmhartog

First attempt at fixing #3405 (closed), by resolving the path using resolve-from, to search up the node_modules hierarchy of the project.

Current status: creating a new project with create-react-app packages/app-a inside a yarn workspaces project succeeds (see #3405 (closed)), but does not yet detect that it should use yarn. All react-scripts files also need to be updated to respect correct paths.

To do: check for each of the following files how they handle paths and substitute an appropriate solution (probably with resolve-from).

  • create-react-app/
    • createReactApp.js
  • react-scripts/
    • init.js
    • build.js
    • eject.js
    • start.js
    • test.js
    • config/
      • paths.js
  • detect use of yarn in a workspace

I'm aware that we'd rather not edit createReactApp.js, but I'm afraid this fix cannot be made without touching it. Would love to hear more thoughts on this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rmhartog/support-yarn-workspaces