Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3455

Add a localhost-only log message pointing folks to the PWA docs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/jeffposnick/additional-sw-logging into master Nov 15, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: jeffposnick

R: @gaearon @Timer

This adds in an additional log message pointing folks to https://goo.gl/SC7cgQ (I could use a different URL shortener or just include the full URL if you'd prefer.)

It's displayed every time registerServiceWorker() is called and there's a service worker active on localhost. Displaying it on each load should give it higher visibility vs. the other logging messages which are only displayed when content is initially cached or content is updated.

I hope it will help with the type of questions that come up at, e.g., https://github.com/facebookincubator/create-react-app/issues/2398#issuecomment-344510011

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/jeffposnick/additional-sw-logging