Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3522

Switch to Babel 7

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/clemmy/2.0-beta into next Nov 30, 2017
  • Overview 56
  • Commits 37
  • Pipelines 0
  • Changes 14

Created by: clemmy

Babel 7 has a lot of new goodies, including JSX fragments. This PR is an attempt to make a pre-release for users to try out Babel 7 with CRA.

Things I'm still trying to mesh out/blocked on:

  • Needed to disable pre-commit hook that runs prettier because it doesn't support JSX fragments, and wouldn't let me commit
  • Need to disable UglifyJsPlugin to make npm run build in react-error-overlay work, can't figure out why
  • Need to add old configuration back into babel-preset-react-app, currently it's overwritten with babel-preset-react
  • Address this PR?
  • Do I need to do anything with Lerna in this PR?
  • Need to re-enable https://github.com/airbnb/babel-plugin-dynamic-import-node. It might be fine to just put it in, but it'll download all the babel 6.x dependencies.
  • Tests are failing. Babel-jest works with Babel 7.x, but jest-runtime depends on Babel 6.x. What's the solution here?

Possibly Relevant Links: https://github.com/webpack/webpack-dev-server/issues/1104#issuecomment-330516760 https://github.com/babel/babel-preset-env/pull/264/files https://github.com/facebook/jest/pull/4557#issuecomment-344202240

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/clemmy/2.0-beta