Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3533
Something went wrong while fetching comments. Please try again.

use safer/more aesthetic syntax for setting environment variables on Windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/cdanielsen/improve-documentation-for-windows-users into master 7 years ago
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: cdanielsen

(Cleaned up version of https://github.com/facebookincubator/create-react-app/pull/3530)

Documentation update to fix a maddeningly easy oversite for Windows users. The SET command allows for wrapping the variable assignment expression with double quotes. Using this method negates the need to smash two commands together with the && operator as currently documented.

Compare
  • master (base)

and
  • latest version
    a7c9c944
    2 commits, 2 years ago

1 file
+ 2
- 2

    Preferences

    File browser
    Compare changes
packages/react-scripts/template/README.md
+ 2
- 2
  • View file @ a7c9c944

  • Edit in single-file editor

  • Open in Web IDE


@@ -890,10 +890,10 @@ life of the shell session.
@@ -890,10 +890,10 @@ life of the shell session.
#### Windows (cmd.exe)
#### Windows (cmd.exe)
```cmd
```cmd
set REACT_APP_SECRET_CODE=abcdef&&npm start
set "REACT_APP_SECRET_CODE=abcdef" && npm start
```
```
(Note: the lack of whitespace is intentional.)
(Note: Quotes around the variable assignment are required to avoid a trailing whitespace.)
#### Linux, macOS (Bash)
#### Linux, macOS (Bash)
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
2
CLA Signed tag: documentation
2
CLA Signed tag: documentation
    Assign labels
  • Manage project labels

Milestone
1.1.0
1.1.0
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!3533
Source branch: github/fork/cdanielsen/improve-documentation-for-windows-users

Menu

Explore Projects Groups Snippets