Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3654

Initialize SW registration when document is already loaded

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/piotr-cz/bugfix/sw-loadevent into master Dec 28, 2017
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: piotr-cz

At this moment, service worker registers a callback to the windows' load event. In some cases (like when there are no images on page), this happens after load event has been fired previously and so callback isn't invoked.

This PR adds a check to see if the document is already loaded (document.readyState === 'complete') and if so, invokes callback manually.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/piotr-cz/bugfix/sw-loadevent