Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3680

Make the threshold whether assets should be inlined configurable for prod builds

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/rogierslag/configurable-asset-inline-limit into master Jan 03, 2018
  • Overview 16
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: rogierslag

For sites which have a large number of images, each of which has a lower probability of being seen, combined with assets which rarely change, the other situation was inconvenient. Users were forced to download the same assets over and over again for unrelated changes.

Apart from that, since each image has a low probability of being loaded, aggressively loading all images is counterproductive.

By making the threshold configurable, but respecting the same default value, developers can use techniques as lazyloading images when applicable (which cannot be done if they are part of the bundle)

Refs https://github.com/facebookincubator/create-react-app/issues/3437

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/rogierslag/configurable-asset-inline-limit