From 27bbabe028e115bdaf9251a3d2b5a65726e6bc00 Mon Sep 17 00:00:00 2001 From: Dan Abramov <dan.abramov@gmail.com> Date: Mon, 15 Jan 2018 17:45:19 +0000 Subject: [PATCH 1/3] Support Jest --watchAll flag --- packages/react-scripts/scripts/test.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/scripts/test.js b/packages/react-scripts/scripts/test.js index ee592d9b1..e73ce232a 100644 --- a/packages/react-scripts/scripts/test.js +++ b/packages/react-scripts/scripts/test.js @@ -33,8 +33,12 @@ if (process.env.SKIP_PREFLIGHT_CHECK !== 'true') { const jest = require('jest'); const argv = process.argv.slice(2); -// Watch unless on CI or in coverage mode -if (!process.env.CI && argv.indexOf('--coverage') < 0) { +// Watch unless on CI in coverage mode, or explicitly running all tests +if ( + !process.env.CI && + argv.indexOf('--coverage') < 0 && + argv.indexOf('--watchAll') < 0 +) { argv.push('--watch'); } -- GitLab From 09068d527337b0faaf8184de5fa761f6ccf7c585 Mon Sep 17 00:00:00 2001 From: Dan Abramov <dan.abramov@gmail.com> Date: Mon, 15 Jan 2018 17:45:41 +0000 Subject: [PATCH 2/3] Use clearer condition --- packages/react-scripts/scripts/test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/scripts/test.js b/packages/react-scripts/scripts/test.js index e73ce232a..0d91e43fd 100644 --- a/packages/react-scripts/scripts/test.js +++ b/packages/react-scripts/scripts/test.js @@ -36,8 +36,8 @@ const argv = process.argv.slice(2); // Watch unless on CI in coverage mode, or explicitly running all tests if ( !process.env.CI && - argv.indexOf('--coverage') < 0 && - argv.indexOf('--watchAll') < 0 + argv.indexOf('--coverage') === -1 && + argv.indexOf('--watchAll') === -1 ) { argv.push('--watch'); } -- GitLab From cb09523db833473bdeb201d3739c76af137470bf Mon Sep 17 00:00:00 2001 From: Dan Abramov <dan.abramov@gmail.com> Date: Mon, 15 Jan 2018 17:49:42 +0000 Subject: [PATCH 3/3] Add comma --- packages/react-scripts/scripts/test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/scripts/test.js b/packages/react-scripts/scripts/test.js index 0d91e43fd..470e8e357 100644 --- a/packages/react-scripts/scripts/test.js +++ b/packages/react-scripts/scripts/test.js @@ -33,7 +33,7 @@ if (process.env.SKIP_PREFLIGHT_CHECK !== 'true') { const jest = require('jest'); const argv = process.argv.slice(2); -// Watch unless on CI in coverage mode, or explicitly running all tests +// Watch unless on CI, in coverage mode, or explicitly running all tests if ( !process.env.CI && argv.indexOf('--coverage') === -1 && -- GitLab