Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !3806

Run `yarn` during ejecting to avoid hoisting issues and fix CI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge fix-ci into next Jan 15, 2018
  • Overview 7
  • Commits 4
  • Pipelines 0
  • Changes 6

Created by: gaearon

Our CI started failing, possibly after Jest released a 21.1.0 update.

After chatting to @byk our best guess is that because we didn't re-run Yarn after ejecting, the new script location (in the root /scripts folder rather than in node_modules/react-scripts/scripts) started picking up a different babel-core version that was previously being hoisted (6.x judging by the stack trace that has /lib/ in it) than the one react-scripts wanted (7.0 bridge).

Our current behavior always seemed weird to me (https://github.com/facebookincubator/create-react-app/issues/3356), and now that it's possibly causing bugs, I think we should try getting rid of that special case. Perhaps those issues in the TODO are not relevant anymore, or maybe we can find better fixes for them. Conceptually re-running yarn sounds like the only right thing to do.

I'm kind of shooting in the dark here so I also tried to update other Jest packages while we're at it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-ci