Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4036

Issue 1394 adding no bin links option

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tdfranklin/issue-1394-adding-no-bin-links-option into next Feb 16, 2018
  • Overview 12
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: tdfranklin

Sorry about so many commit's. I forgot to set autocrlf to false (I'm working in Windows) so went back and set that which looks like it changed the whole file to fix the line endings. I'll just note below what lines I actually added code to for your review:

Line 79 - added option for --no-bin-links Line 163 - passed program.binLinks to createApp() Line 167 - added binLinks as arg to createApp() Line 228 - passed binLinks to run() Line 249 - added binLinks as arg to install() Lines 289-291 - if statement to push --no-bin-links to npm args Line 311 - added binLinks as arg to run() Line 342 - passed binLinks to install()

I added a few console.log's when testing to make sure argument was only being passed when it was called. Running create-react-app my-app should have no changes. You would need to run create-react-app my-app --use-npm --no-bin-links which should then pass the --no-bin-links command to npm. When I tested those flags, the process completed without any errors.

Please let me know if there are any further changes you would like me to make or if I did not do something correctly. Thank you!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tdfranklin/issue-1394-adding-no-bin-links-option