Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4138

Allow ModuleScopePlugin accecpts an array as its appSrc

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/froyog/next into next Mar 10, 2018
  • Overview 3
  • Commits 4
  • Pipelines 0
  • Changes 2

Created by: froyog

When ejected, you can now pass in an array as the appSrc for ModuleScopPlugin. Implement of #4079 (closed)

test plan:

  1. yarn create-react-app test-app
  2. cd test-app
  3. yarn run eject
  4. mkdir docs
  5. In config/paths.js, add docsSrc: resolveApp('docs')
  6. In config/webpack.config.dev.js, modify new ModuleScopePlugin(paths.appSrc, [paths.appPackageJson]), to new ModuleScopePlugin([paths.appSrc, paths.docsSrc], [paths.appPackageJson]),
  7. yarn start. You should be able to import stuff from both src/ and docs/.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/froyog/next