Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4377

Updates to the modern code style

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/vtereshyn/next into next 7 years ago
  • Overview 5
  • Commits 2
  • Pipelines 0
  • Changes 2

Created by: vtereshyn

There are few changes in the code style. I've attached two screenshots with my changes. You can see that I simplified 'if statement' at first screenshot and you can see that I changed a string to template string at the second. if_simplified screenshot at apr 28 16-53-51

Compare
  • next (base)

and
  • latest version
    938d03b2
    2 commits, 2 years ago

2 files
+ 10
- 14

    Preferences

    File browser
    Compare changes
pack‎ages‎
create-r‎eact-app‎
inde‎x.js‎ +8 -10
react-d‎ev-utils‎
eslintFor‎matter.js‎ +2 -4
packages/create-react-app/index.js
+ 8
- 10
  • View file @ 938d03b2


@@ -43,16 +43,14 @@ var semver = currentNodeVersion.split('.');
var major = semver[0];
if (major < 4) {
console.error(
chalk.red(
'You are running Node ' +
currentNodeVersion +
'.\n' +
'Create React App requires Node 4 or higher. \n' +
'Please update your version of Node.'
)
);
process.exit(1);
console.error(
chalk.red(
`You are running Node ${currentNodeVersion}.
Create React App requires Node 4 or higher.
Please update your version of Node.`
)
);
process.exit(1);
}
require('./createReactApp');
packages/react-dev-utils/eslintFormatter.js
+ 2
- 4
  • View file @ 938d03b2


@@ -12,10 +12,8 @@ const stripAnsi = require('strip-ansi');
const table = require('text-table');
function isError(message) {
if (message.fatal || message.severity === 2) {
return true;
}
return false;
return !!(message.fatal || message.severity === 2);
}
function formatter(results) {
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
CLA Signed
1
CLA Signed
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: facebook/create-react-app!4377
Source branch: github/fork/vtereshyn/next

Menu

Explore Projects Groups Snippets