Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4424

ensureSlash: Fix accidental string-to-NaN coercion

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/wchargin/wchargin-ensureslash-accidental-coercion into next May 08, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: wchargin

Summary: The hasSlash method uses path.substr(path, path.length - 1) to remove the last character from path. Clearly, the first parameter is suspect; it should be 0. The code works as written, but only very accidentally: the first parameter is coerced by ToNumber to NaN, which is then coerced by ToInteger to +0, per the spec.

Test Plan: Reading the spec should be sufficient. To verify in the Real World:

const path = "has-slash-but-does-not-need-slash/"
const a = path.substr(path, path.length - 1);
const b = path.substr(0, path.length - 1);
console.log(a === b);  // true
console.log(a);        // has-slash-but-does-not-need-slash

wchargin-branch: ensureslash-accidental-coercion

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/wchargin/wchargin-ensureslash-accidental-coercion