Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4490

Webpack4

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bugzpodder/webpack4 into next May 20, 2018
  • Overview 5
  • Commits 19
  • Pipelines 0
  • Changes 4

Created by: bugzpodder

All e2e tests passes locally, trying out CI builds with this PR since I can't merge directly to the other two PRs.

Three new changes:

  • Disabled concatenateModules in production build because it breaks WebpackManifestPlugin https://github.com/facebook/create-react-app/pull/4077#issuecomment-389270627
  • Changes jsdom options to fetch stylesheet links properly (instead of causing a timeout)
  • Fixed inline/external CSS validation in kitchensink test. https://github.com/facebook/create-react-app/pull/4481#issuecomment-390110440
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bugzpodder/webpack4