Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4552

Use URL of script instead of window.location for dev server

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/morrislaptop/patch-1 into next Jun 02, 2018
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: morrislaptop

In my scenario, the page is being served by PHP and the URL to the bundle is pointed directly to the webpack dev server.

So, the website is being served at http://my-project.test and the script is pointing to http://localhost:8080/app.js.

By using window.location for the webpack dev server client, it is forcing the sockjs server to be on the same domain as the page. However, it's more accurate to get the dev server from the script.

Reference:

  • https://github.com/egoist/poi/pull/448
  • https://github.com/morrislaptop/WebpackDevServerValetDriver
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/morrislaptop/patch-1