Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4642

Add support for .mjs extension from dependencies (such as graphql)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/christemple/next into next Jun 18, 2018
  • Overview 12
  • Commits 1
  • Pipelines 0
  • Changes 7

Created by: christemple

Here is the fix for supporting .mjs files from dependencies referenced here: https://github.com/facebook/create-react-app/issues/4637

I've verified the changes both before and after, here's the after screenshot:

graphql loaded successfully

I tried writing some tests for the .mjs support but failed to get the e2e docker tests running on my local machine after following this guide (was failing with user permissions?)

I'm hoping that CI will pick it up and run smoothly, if not I'd really appreciate some help in getting the tests to run locally 👍

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/christemple/next