Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • C create-react-app
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,547
    • Issues 1,547
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 417
    • Merge requests 417
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Meta
  • create-react-app
  • Merge requests
  • !4656

Fix error with formatWebpackMessages trimming warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/marcofugaro/format-webpack-message-update into next Jun 20, 2018
  • Overview 6
  • Commits 4
  • Pipelines 0
  • Changes 1

Created by: marcofugaro

Hey, I've been using the updated react-dev-utils and found a bug in formatWebpackMessages that happens with newer webpack versions.

Basically webpack (or the thread-loader) in the stats.toJson().warnings now outputs also this line, containing a Module Warning or Module Error (?):

Module Warning (from ./node_modules/thread-loader/dist/cjs.js):

so the lines array now becomes this (see second line):

screen shot 2018-06-20 at 19 02 19

instead of the old one

screen shot 2018-06-20 at 19 02 32

This fucks with the thread-loader message remover and actually removes the body of the warning.

This PR checks if that line is present and removes it since it's not relevant to the user.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/marcofugaro/format-webpack-message-update